Replace function with procedure declaration when no return specified #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Oh, thanks. I will merge this. Sorry for not responding, had a lot of stuff to do. |
Owner
|
Great, now everything breaks on 1.2019.09 (my local version). |
Author
|
Sorry to hear that 😏 I guess keeping backward compatibility is not a virtue that plantuml can be proud of 😅 |
Owner
|
Yes yes, not the first time stuff breaks. Managed to get it working though, struggling with the branches now. I think I will tag commits with the plantuml version from now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
In the latest release of plantuml (V1.2020.7), if a function does not have a return directive we will get an error.
See changes at plantuml/plantuml@9077d97, in the
CodeIteratorReturnFunction.javaI've changed every
functiondeclaration toprocedurewhere there is nothing returned.