Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Persistent Volume Claim (PVC) support for K8s local cache #1

Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open

Persistent Volume Claim (PVC) support for K8s local cache #1

wants to merge 25 commits into from

Conversation

stephanschielke
Copy link

Will add a new config entry in values.yaml for pvc.
If create: true it will add a PersistentVolumeClaim
The volume is mounted into the deployment container.

Example values.yaml

config:
  storageProvider: "local"
  storagePath: "/tmp/turborepo"
  storagePathUseTmpFolder: "true"

pvc:
  create: true
  storageClassName: "efs-sc"
  storageSize: "50Gi"
  accessModes:
    - ReadWriteMany

adriantr
adriantr requested changes Feb 22, 2023
View reviewed changes
Copy link
Owner

@adriantr adriantr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments

turborepo-remote-cache/templates/deployment.yaml Outdated Show resolved Hide resolved
turborepo-remote-cache/templates/storage.yaml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adriantr adriantr adriantr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stephanschielke @adriantr