fix: add cursor-dev-path.sh for VS Code tasks; link deploy docs - #5
Conversation
Co-authored-by: adrian stanca <adrianstanca1@users.noreply.github.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (14)
📝 WalkthroughWalkthroughThe PR introduces a new Cursor local-handbook skill with philosophy, methodology, and memory documentation; adds MCP and editor configuration templates with deployment automation; updates development environment path handling; and refreshes package dependencies with documentation navigation links. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
- axios, react, react-dom, @types/bun, lru-cache, turndown, fuse.js, @mendable/firecrawl-js to latest compatible releases within semver. - Verified with bun run smoke. Made-with: Cursor
Bump @opentelemetry/* packages to 2.7.0, @grpc/grpc-js to 1.14.3, and @types/node to 25.6.0 so optional telemetry paths resolve cleanly. Verified with bun run smoke. Made-with: Cursor
Include apply-machine-config.sh, config mirrors, and ignore machine-only .claude/.remember paths under the skill directory. Made-with: Cursor
Made-with: Cursor
Made-with: Cursor
| --- | ||
| name: local-handbook | ||
| description: >- | ||
| Personal playbook (handbook v2, 2026-04). Before substantial edits, debugging, | ||
| ambiguous scope, or multi-step work: read logic.md then memory.md. User’s | ||
| explicit Cursor instructions override this skill when they conflict. Append | ||
| memory.md when the user states a durable preference or corrects a mistake | ||
| that should persist. | ||
| --- | ||
|
|
||
| # Local handbook | ||
|
|
||
| Companion files turn generic model behavior into **repeatable, verifiable** work on this machine and in mirrored repos. | ||
|
|
||
| ## Files | ||
|
|
||
| | File | Read for | | ||
| |------|-----------| | ||
| | `logic.md` | Reasoning, verification gates, safety, git/MCP habits. | | ||
| | `memory.md` | Facts that should survive across sessions (paths, remotes, prefs). | | ||
| | `config/` | Versioned **MCP** + **Cursor** settings snapshots; see `config/README.md`. | | ||
| | `scripts/apply-machine-config.sh` | Copies `config/mcp*.json` to `~/.claude` and refreshes `~/.cursor/mcp.json` symlink. | | ||
|
|
||
| ## When this skill applies | ||
|
|
||
| - Implementing or refactoring **non-trivial** behavior. | ||
| - Debugging failures, flaky tests, or unclear stack traces. | ||
| - Touching **auth, payments, migrations, deploy**, or anything irreversible without an explicit green light. | ||
| - The user’s ask is **ambiguous** — clarify briefly, then proceed with stated assumptions. | ||
|
|
||
| ## Boot checklist (do in order) | ||
|
|
||
| 1. Skim **`memory.md`** for this scope (global vs repo section). | ||
| 2. If the repo has **`AGENTS.md`**, **`CLAUDE.md`**, or **`SESSION.md`**, read the relevant one before large edits. | ||
| 3. Choose the **narrowest** verify command that matches the change (see repo `memory.md` where listed). | ||
| 4. After edits, **run** that command; report failures with evidence, not guesses. | ||
|
|
||
| ## Progressive disclosure | ||
|
|
||
| - **Project rules win** over this handbook when they conflict. | ||
| - Prefer **existing patterns** in the codebase over new abstractions unless the task requires them. | ||
| - Use **MCP tools** when configured and they reduce ambiguity (docs, tickets, CI); handle tool errors without pretending success. | ||
|
|
||
| ## Maintenance | ||
|
|
||
| - Keep `memory.md` **short** (bullets, not essays). Move long narratives to project `CLAUDE.md` / `AGENTS.md`. | ||
| - Keep `logic.md` about **process**, not secrets or one-off ticket dumps. |
There was a problem hiding this comment.
🔴 PR ships .cursor/ editor-only tree, violating AGENTS.md mandatory rule
AGENTS.md (line 54) contains a mandatory rule: "This repository does not ship editor-only trees (for example .cursor/ or team-local MCP pins) on main. Keep personal or team agent configuration outside the repo or in your fork only, so the upstream tree stays neutral for all contributors." This PR adds the entire .cursor/skills/local-handbook/ directory (10 files including SKILL.md, logic.md, memory.md, MCP configs, Cursor settings, and shell scripts), which is exactly the kind of .cursor/ editor-only tree the rule prohibits. The directory also contains hardcoded personal machine paths (/Users/adrianstanca/Desktop, /Users/adrianstanca/cortexbuild-ultimate, etc. in mcp.json:52-56), personal Cursor settings with user-specific PATH entries (cursor-user-settings.json:48), and session-specific notes in memory.md — none of which belong in a shared upstream tree.
Prompt for agents
The entire .cursor/skills/local-handbook/ directory must be removed from this PR to comply with the AGENTS.md rule at line 54 which states: 'This repository does not ship editor-only trees (for example .cursor/ or team-local MCP pins) on main. Keep personal or team agent configuration outside the repo or in your fork only, so the upstream tree stays neutral for all contributors.' All 10 files under .cursor/skills/local-handbook/ should be deleted from version control. Consider adding .cursor/ to the root .gitignore to prevent accidental future commits. The personal handbook can live in a separate private repo (the memory.md already references https://github.com/adrianstanca1/cursor-local-handbook.git for this purpose).
Was this helpful? React with 👍 or 👎 to provide feedback.
| "filesystem": { | ||
| "command": "/opt/homebrew/bin/npx", | ||
| "args": [ | ||
| "-y", | ||
| "@modelcontextprotocol/server-filesystem", | ||
| "/Users/adrianstanca/Desktop", | ||
| "/Users/adrianstanca/cortexbuild-ultimate", | ||
| "/Users/adrianstanca/autoresearch-trio", | ||
| "/Users/adrianstanca/Desktop/openclaude-main", | ||
| "/Users/adrianstanca/skills" | ||
| ], |
There was a problem hiding this comment.
🔴 MCP config commits hardcoded personal filesystem paths exposing user's directory structure
.cursor/skills/local-handbook/config/mcp.json lines 52–56 hardcode the filesystem MCP server with access scoped to personal directories: /Users/adrianstanca/Desktop, /Users/adrianstanca/cortexbuild-ultimate, /Users/adrianstanca/autoresearch-trio, /Users/adrianstanca/Desktop/openclaude-main, /Users/adrianstanca/skills. Similarly, cursor-user-settings.json:48 hardcodes /Users/adrianstanca/.local/bin in the terminal PATH. These machine-specific paths are useless for any other contributor and expose the author's local directory layout in a public repository. This compounds the AGENTS.md violation — these are personal/team-local MCP pins that should not be in the repo.
Was this helpful? React with 👍 or 👎 to provide feedback.
Summary
scripts/cursor-dev-path.sh, which prepends common Bun install locations toPATHandexecs the remaining arguments. This matches what.vscode/tasks.jsonanddocs/deploy.mdalready reference so Run Task works when the IDE starts with a minimalPATH.AGENTS.md(environment + commands table) and restore README links todocs/deploy.mdfor discoverability.Impact
bunwithout manual shell PATH fixes on typical macOS layouts.Testing
bun run buildbun run smokebash -n scripts/cursor-dev-path.shandscripts/cursor-dev-path.sh true(this environment has no Bun)Notes
~/.bun/bin, Homebrew (/opt/homebrew/bin,/usr/local/bin), mise shims. Contributors on Linux can still rely on a normal login shell or extend the script in a follow-up if needed.Summary by CodeRabbit
Release Notes
New Features
Documentation
Chores