Skip to content

[Forwardport] use "Module_Name::template/path" format instead of using template/path i…#13

Merged
adrian-martinez-interactiv4 merged 1 commit into2.3-developfrom
2.3-develop-PR-port-14946
Oct 8, 2018
Merged

[Forwardport] use "Module_Name::template/path" format instead of using template/path i…#13
adrian-martinez-interactiv4 merged 1 commit into2.3-developfrom
2.3-develop-PR-port-14946

Conversation

@adrian-martinez-interactiv4
Copy link
Copy Markdown
Owner

Original Pull Request

magento#14946
…n Block class to ensure extensibility of the class. not doing so causes invalid template errors after extending the block class via preference

Description

Often third party modules override core block classes. If the source block classes reference a template without specifying module name like "Vendor_Module::template_path" then block render fails with "nvalid template file: " error.

Manual testing scenarios

  1. Overide the \Magento\Review\Block\Product\ReviewRenderer Block in your custom module via di preference. Leave your custom class empty.
  2. Product details should work.

Contribution checklist

  • [ x] Pull request has a meaningful description of its purpose
  • [ x] All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

…n Block class to ensure extensibility of the class. not doing so causes invalid template errors after extending the block class via preference
@adrian-martinez-interactiv4 adrian-martinez-interactiv4 merged commit 44a1f2b into 2.3-develop Oct 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants