Conversation
|
@adrhill I implemented |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #238 +/- ##
===========================================
- Coverage 93.82% 60.05% -33.78%
===========================================
Files 30 31 +1
Lines 1183 1154 -29
===========================================
- Hits 1110 693 -417
- Misses 73 461 +388 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hmm it looks like the problem is that e.g. using RecursiveArrayTools
u = NamedArrayPartition(; foo=rand(5))
similar(u, Int)yields the output |
| @@ -0,0 +1,12 @@ | |||
| using RecursiveArrayTools | |||
There was a problem hiding this comment.
Looks like this is missing from the test environment.
| u = NamedArrayPartition(; foo=rand(5)) | ||
| du = copy(u) | ||
|
|
||
| jacobian_sparsity(f!, du, u, TracerSparsityDetector()) No newline at end of file |
There was a problem hiding this comment.
Would be nice to have a slightly more rigorous test than just a dry-run.
I don't know the functionality of NamedArrayPartition, but the tests should cover as much of it as possible.
|
So |
|
Closing this PR as this was fixed by SciML/RecursiveArrayTools.jl#431. |
Fixes #237.