Fix: Block drag start while any item is busy & add wait for transition end in test helper drop
#562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ess in drag test helper
| @@ -108,4 +108,11 @@ export async function drag(mode, itemSelector, offsetFn, callbacks = {}) { | |||
| await callbacks.dragend(); | |||
| await settled(); | |||
| } | |||
|
|
|||
| await waitUntil( | |||
There was a problem hiding this comment.
is this still needed? wouldn't settled state already be bring us to when there is no .is-dropping?
There was a problem hiding this comment.
the problem is, that there is no waiting for transitionEnd, for this reason we need to wait... only adding await settled() will not fix the problem 😒
NullVoxPopuli
approved these changes
Jun 20, 2024
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While added direction
gridin PR #560 we have discovered, that the waiting fortransitionEndwas not correctly. This has some side-effects in tests, when using with a bigger list of item, because the animation spents more time.This was the reason, why added tests for direction
gridwere failed.This PR fix following bugs
drophelper hasn't respectedtransitionEnd, caused by the other two bugs. Fast reordering like in tests are not working with large lists