Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify CI #533

Merged
merged 3 commits into from
Dec 20, 2023
Merged

Simplify CI #533

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9960c13
Simplify CI
NullVoxPopuli Dec 20, 2023
7e3adc0
Missed some try scenarios
NullVoxPopuli Dec 20, 2023
56a4c00
Update lint
NullVoxPopuli Dec 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 0 additions & 30 deletions .github/actions/assert-build/action.yml
View file
Open in desktop

This file was deleted.

15 changes: 0 additions & 15 deletions .github/actions/download-built-package/action.yml
View file
Open in desktop

This file was deleted.

14 changes: 0 additions & 14 deletions .github/actions/setup-job/action.yml
View file
Open in desktop

This file was deleted.

62 changes: 19 additions & 43 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,28 +8,17 @@ on:
pull_request: {}

concurrency:
group: ci-${{ github.head_ref || github.ref }}
cancel-in-progress: true
group: ci-${{ github.head_ref || github.ref }}
cancel-in-progress: true

jobs:
# Fills the dep cache so parallel jobs can start faster
setup:
name: Setup
name: "Setup"
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: ./.github/actions/setup-job
- uses: ./.github/actions/assert-build

lint:
name: Lint
runs-on: ubuntu-latest
needs: [setup]

steps:
- uses: actions/checkout@v4
- uses: ./.github/actions/setup-job
- name: Lint
run: pnpm lint
- uses: wyvox/action-setup-pnpm@v3

test:
name: "Tests"
Expand All @@ -38,26 +27,19 @@ jobs:

steps:
- uses: actions/checkout@v4
- uses: ./.github/actions/setup-job
- uses: ./.github/actions/download-built-package
- name: Run Tests
run: pnpm test:ember
working-directory: test-app
- uses: wyvox/action-setup-pnpm@v3
- run: pnpm test

docs:
name: "Docs App"
lint:
name: "Lint"
runs-on: ubuntu-latest
# This isn't a strict requirement, but it doesn't make
# sense to test the docs app if the main tests are not passing
needs: [test]
needs: [setup]

steps:
- uses: actions/checkout@v4
- uses: ./.github/actions/setup-job
- uses: ./.github/actions/download-built-package
- name: Run Tests
run: pnpm test:ember
working-directory: docs
- uses: wyvox/action-setup-pnpm@v3
- name: Lint
run: pnpm lint

floating:
name: "Floating Dependencies"
Expand All @@ -66,15 +48,10 @@ jobs:

steps:
- uses: actions/checkout@v4
- uses: ./.github/actions/setup-job
- uses: ./.github/actions/download-built-package
- name: Install Dependencies
run: |
rm pnpm-lock.yaml
pnpm install
- name: Run Tests
run: pnpm test:ember
working-directory: test-app
- uses: wyvox/action-setup-pnpm@v3
with:
args: '--no-lockfile'
- run: pnpm test

try-scenarios:
name: ${{ matrix.try-scenario }}
Expand All @@ -100,8 +77,7 @@ jobs:

steps:
- uses: actions/checkout@v4
- uses: ./.github/actions/setup-job
- uses: ./.github/actions/download-built-package
- uses: wyvox/action-setup-pnpm@v3
- name: Run Tests
run: node_modules/.bin/ember try:one ${{ matrix.try-scenario }} --skip-cleanup
run: ./node_modules/.bin/ember try:one ${{ matrix.try-scenario }} --skip-cleanup
working-directory: test-app