Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

importing from the _app_ directory was disallowed because of the exports config. #521

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

NullVoxPopuli
Copy link
Contributor

@NullVoxPopuli NullVoxPopuli commented Dec 6, 2023

Looks like none of the _app_ files are importable.

this is an issue I thought we would have encountered sooner:

You tried to reverse exports for the file
   `./dist/_app_/modifiers/sortable-group.js` 
   in package `ember-sortable` but it does not match any 
   of the exports rules defined in package.json. 
   This means it should not be possible to access directly.

ember-sortable is a v2 addon already, but forgot to re-export their _app_ directory:

  "exports": {
    ".": "./dist/index.js",
    "./modifiers/*": "./dist/modifiers/*",
    "./services/*": "./dist/services/*",
    "./test-support": "./dist/test-support/index.js",
    "./addon-main.js": "./addon-main.js"
  },

😅

Discussion: https://discord.com/channels/480462759797063690/1182017862651629601/1182019040785473566

--------------_

Note, by default, this sort of change isn't needed, as the blueprint includes app already:

".": "./dist/index.js",
"./*": "./dist/*.js",
"./test-support": "./dist/test-support/index.js",
"./addon-main.js": "./addon-main.cjs"

@knownasilya knownasilya merged commit a7f554f into master Dec 20, 2023
15 checks passed
@knownasilya knownasilya deleted the NullVoxPopuli-patch-1 branch December 20, 2023 12:19
@github-actions github-actions bot mentioned this pull request Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants