Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add '@ember/string' dev dependency to avoid deprecation warning #610

Merged
merged 1 commit into from
Feb 2, 2023
Merged

Add '@ember/string' dev dependency to avoid deprecation warning #610

merged 1 commit into from
Feb 2, 2023

Conversation

pzubar
Copy link
Contributor

@pzubar pzubar commented Feb 2, 2023

Ember started showing a lot of deprecation warnings which seemed to be triggered by the "ember-resolver addon" used in the dummy app:

DEPRECATION: Importing from `@ember/string` without having the `@ember/string` package in your project is deprecated. Please add `@ember/string` to your `package.json [deprecation id: ember-string.add-package] This will be removed in ember-source 5.0.0. See https://deprecations.emberjs.com/v4.x/#toc_ember-string-add-package for more details.

The latest addon version adds a fix to avoid this warning.

I think it might be useful to fix this warning in order to make working on the addon updates more comfortable.

jelhan
jelhan approved these changes Feb 2, 2023
View reviewed changes
Copy link
Contributor

@jelhan jelhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for taking care of it!

@jelhan jelhan merged commit 3c26b87 into adopted-ember-addons:main Feb 2, 2023
@jelhan jelhan added the internal label Feb 2, 2023
@jelhan jelhan changed the title Add '@ember/string' dependency to avoid the deprecation warning Add '@ember/string' dev dependency to avoid the deprecation warning Feb 2, 2023
@jelhan jelhan changed the title Add '@ember/string' dev dependency to avoid the deprecation warning Add '@ember/string' dev dependency to avoid deprecation warning Feb 2, 2023
@pzubar pzubar deleted the adds-ember-string-to-dependencies branch February 7, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jelhan jelhan jelhan approved these changes

Assignees
No one assigned
Labels
internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pzubar @jelhan