Fix: Add ...attributes to lt-body #825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI @rwwagner90, as mentioned on Discord |
|
@IgnaceMaes I think this needs a rebase now that CI is green. |
|
Synced the fork via GitHub, that should do it? |
RobbieTheWagner
approved these changes
Jan 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In MR #798 the
lt-bodycomponent has been made tagless. As the template doesn't contain...attributesit's impossible to e.g. set an id or pass a modifier on the body. Is this an intention breaking change?If not, this adds it back like it used to work in v3.0.0-beta.0.