Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove jQuery usage #593

Merged

Conversation

donaldwasserman
Copy link
Contributor

Fixes #591

CC: @alexander-alvarez I left usage of this.$().text().trim in the test blueprint. I'm going to make a seperate PR for updating ember + friends so we can get qunit dom working.

I'm also going to make a PR against ember-scrollable to remove that little bit of jQuery as well.

@donaldwasserman donaldwasserman changed the base branch from master to 2-x October 28, 2018 13:45
@alexander-alvarez
Copy link
Collaborator

@donaldwasserman LGTM! Thanks so much for taking the initiative on this 👏

@alexander-alvarez alexander-alvarez merged commit 9ca4931 into adopted-ember-addons:2-x Oct 29, 2018
@alexander-alvarez
Copy link
Collaborator

Released as [email protected] and ember-light-table@next

@donaldwasserman
Copy link
Contributor Author

Happy to help - I’m working on the ember-scrollable piece right now. Hopefully have that done this week. Maybe you know someone who can get that merged in 😜

Do you know of anything else that uses jQuery in here?

@alexander-alvarez
Copy link
Collaborator

Maybe you know someone who can get that merged in
Yup, I can do that for you when it's ready. I'm trying to get out of your way as much as possible

I don't think there is any, but we should be able to do a jquery-less build and if tests pass then 👍
maybe rip-off
https://github.com/cibernox/ember-power-select/blob/master/config/ember-try.js
https://github.com/emberjs/ember-optional-features

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants