Use abs position when checking if element is visible in viewport #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`clientHeight` doesn't tell us anything about where the `viewPortElem` is located in the window relative to where `this.elem` is located. Using absolute values ensures that `_debounceScrolledToBottom()` is always called when the `infinity-loader` component is in view.
snewcomer
approved these changes
May 19, 2021
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While implementing ember-infinity in my project I noticed that the
<InfinityLoader>would be in view but would not load new records. One simple way of testing this was to have an endpoint that returns 1 record per page. ember-infinity loads the first page,<InfinityLoader>remains in view, and no new records are loaded.This PR contains the fix I came up with which resolve the issue.
clientHeightdoesn't tell us anything about where theviewPortElemis located in the window relative to wherethis.elemis located. Using absolute values ensures that_debounceScrolledToBottom()is always called when the<InfinityLoader>component is in view.