Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove tagName from loader component to remove isVisible #416

Merged
merged 6 commits into from
Jan 25, 2020
Merged

Remove tagName from loader component to remove isVisible #416

merged 6 commits into from
Jan 25, 2020

Conversation

snewcomer
Copy link
Collaborator

@snewcomer snewcomer commented Jan 25, 2020 •
edited
Loading

This will get rid of the deprecation warning around isVisible as we will manage it explicitly.

close #415

@snewcomer snewcomer self-assigned this Jan 25, 2020
@snewcomer snewcomer changed the title Remove tagName from loader Remove tagName from loader component Jan 25, 2020
@snewcomer snewcomer added dependencies Pull requests that update a dependency file enhancement labels Jan 25, 2020
@snewcomer snewcomer merged commit 56adc26 into master Jan 25, 2020
@snewcomer snewcomer mentioned this pull request Jan 25, 2020
Closed
@snewcomer snewcomer changed the title Remove tagName from loader component Remove tagName from loader component to remove isVisible Jan 25, 2020
@DuBistKomisch
Copy link
Contributor

seems to be working here, thanks 😄

@snewcomer snewcomer deleted the sn/refactor-loader-2 branch March 12, 2020 04:10
@DuBistKomisch DuBistKomisch mentioned this pull request Apr 30, 2020
Merged
@smercadomx smercadomx mentioned this pull request Jan 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@snewcomer snewcomer

Labels
dependencies Pull requests that update a dependency file enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

isVisible is deprecated in 3.15
2 participants
@snewcomer @DuBistKomisch