[EMBER]: upgrade to 2.8 and remove DS check #215
Conversation
|
Running this test here and seems as though in test land Ember's event handling has changed and for some reason the height/distance of items in the DOM are also different. Need to figure out where/why this has changed to be able to modify the tests. master ember 2.4 ember-cli-qunit <= 2.1 this branch ember 2.8 ember-cli-qunit > 2.1 |
|
Ok so what is interesting is upgrading from |
|
@hhff this PR is passing now. A few other things other than upgrading are listed above. Will look into the ember-cli-qunit change that causes the difference above, but we could merge in as is. |
ember-cli-build.js
Outdated
| @@ -4,7 +4,9 @@ var EmberAddon = require('ember-cli/lib/broccoli/ember-addon'); | |||
|
|
|||
| module.exports = function(defaults) { | |||
| var app = new EmberAddon(defaults, { | |||
| // Add options here | |||
| babel: { | |||
There was a problem hiding this comment.
Take care of Object assign not existing in < ie 11?
|
@snewcomer - in the past I've done |
|
@snewcomer - right now, a user can't use Ember Infinity without Ember Data (this.store.find or this.store.query are both ED methods) |
|
re: Ember Data - I would like to remove the dep on Ember-Version-Is however... |
|
@hhff I think the case for the util is if <=ie11 and no Ember.assign. Also here is an acceptance test using a custom store and custom find method :). Let me know your thoughts. |
|
Awesome work. I'm cool with all of this. Ok for me to merge? |
snewcomer
changed the title
|
@hhff yep if you are good with these changes! |
References #214
moduleForAcceptance