Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin incompatible dependencies #431

Merged
merged 1 commit into from
Apr 20, 2021
Merged

Pin incompatible dependencies #431

merged 1 commit into from
Apr 20, 2021

Conversation

gilest
Copy link
Collaborator

@gilest gilest commented Apr 17, 2021

As sub-dependencies out in the wild have been updated they have caused the "Floating Dependencies" builds to fail.

ember-data: Too permissive. The latest version 3.26 was being installed. Incompatible with the existing setup

whatwg-fetch: Incompatible version. Should be cleared up when we next upgrade addon-docs. (ember-cli/ember-fetch#547)
@gilest gilest requested a review from jelhan April 17, 2021 23:03
Copy link
Collaborator

@jelhan jelhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Scenarios for beta and canary releases of Ember are still failing. But I guess that's not related.

@gilest gilest merged commit cac3a08 into master Apr 20, 2021
@gilest gilest deleted the pin-dependencies branch April 20, 2021 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants