Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress goes straight to 100% when starting a file upload #1013

Closed
2 tasks done
gilest opened this issue Nov 3, 2023 · 1 comment · Fixed by #1017
Closed
2 tasks done

Progress goes straight to 100% when starting a file upload #1013

gilest opened this issue Nov 3, 2023 · 1 comment · Fixed by #1017

Comments

@gilest
Copy link
Collaborator

gilest commented Nov 3, 2023

Had this reported to me via Discord DM.

Suspect there is variance between the HTTP responses, timing etc of different users' upload endpoints, possibly includes browser implementation variance also.

Ref:
#1002
#1005
#1007

Suggested way forward

Preview Give feedback

Upload telemetry could be gathered by adding logging to the upload function directly in node_modules

image

gilest added a commit that referenced this issue Nov 10, 2023
Skips the browser, http, network etc. and lets us test the smallest unit of our internals – an UploadFile having its state updated by a series of ProgressEvent events.

For each scenario I'm pretty sure we only need to test a single file with a stream of synchronous events.

Covers some recorded events from different browsers and endpoints. We can add more scenarios here if we come across them.

Specifically, the Chrome scenario proves the fix in #1016 – this was previously failing early with 100% progress, which is the same issue reported by users in #1013

I've painstakingly copied values from log screenshots to setup this existing suite. Hopefully contributors can PR full tests in future to make things a bit easier 😅

Fixes #1013
@gilest
Copy link
Collaborator Author

gilest commented Nov 10, 2023

Fix released in 8.3.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant