Skip to content

Commit

Permalink
Ensure type imports and exports are explicit (#1009)
Browse files Browse the repository at this point in the history
Required as @tsconfig/ember has added "verbatimModuleSyntax": true,

tsconfig/bases@aacda43

Labelled as enhancement because I'm not sure how this affects the public QueueName type export

Ref: failing build #1008
  • Loading branch information
gilest authored Oct 30, 2023
1 parent d587710 commit 04fc344
Show file tree
Hide file tree
Showing 7 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion ember-file-upload/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export {
FileSource,
FileState,
// Interfaces
QueueName,
type QueueName,
// Constants
DEFAULT_QUEUE,
};
2 changes: 1 addition & 1 deletion ember-file-upload/src/services/file-queue.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import Service from '@ember/service';
import { registerDestructor } from '@ember/destroyable';
import { Queue } from '../queue.ts';
import type { UploadFile } from '../upload-file.ts';
import { QueueName } from '../interfaces.ts';
import type { QueueName } from '../interfaces.ts';
import { TrackedMap } from 'tracked-built-ins';

export const DEFAULT_QUEUE = Symbol('DEFAULT_QUEUE');
Expand Down
2 changes: 1 addition & 1 deletion ember-file-upload/src/system/data-transfer-wrapper.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { FileUploadDragEvent } from '../interfaces.ts';
import type { FileUploadDragEvent } from '../interfaces.ts';

const getDataSupport = {};

Expand Down
4 changes: 2 additions & 2 deletions ember-file-upload/src/system/drag-listener-modifier.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import Modifier, { ArgsFor, NamedArgs } from 'ember-modifier';
import { DragListenerModifierSignature } from '../interfaces.ts';
import Modifier, { type ArgsFor, type NamedArgs } from 'ember-modifier';
import type { DragListenerModifierSignature } from '../interfaces.ts';
import DragListener from './drag-listener.ts';
import { registerDestructor } from '@ember/destroyable';
import type Owner from '@ember/owner';
Expand Down
2 changes: 1 addition & 1 deletion ember-file-upload/src/system/http-request.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { bind } from '@ember/runloop';
import RSVP from 'rsvp';
import { HTTPRequestOptions } from '../interfaces.ts';
import type { HTTPRequestOptions } from '../interfaces.ts';

function parseHeaders(headerString: string) {
return headerString
Expand Down
2 changes: 1 addition & 1 deletion ember-file-upload/src/system/upload.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import HTTPRequest from './http-request.ts';
import RSVP from 'rsvp';
import { waitForPromise } from '@ember/test-waiters';
import type { UploadFile } from '../upload-file.ts';
import { FileState, UploadOptions } from '../interfaces.ts';
import { FileState, type UploadOptions } from '../interfaces.ts';

function clone(object: object | undefined) {
return object ? { ...object } : {};
Expand Down
2 changes: 1 addition & 1 deletion ember-file-upload/src/upload-file.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import UploadFileReader from './system/upload-file-reader.ts';
import type { Queue } from './queue.ts';
import { guidFor } from '@ember/object/internals';
import RSVP from 'rsvp';
import { FileSource, FileState, UploadOptions } from './interfaces.ts';
import { FileSource, FileState, type UploadOptions } from './interfaces.ts';

/**
* Files provide a uniform interface for interacting
Expand Down

0 comments on commit 04fc344

Please sign in to comment.