Convert to a v2 addon and drop support for Ember < 3.16 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I ran ember `init -b @embroider/addon-blueprint@latest --pnpm` and moved things around a bit
✅ Deploy Preview for ember-drag-drop ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@dgavey any objection on me moving this forward? After this is merged I'll setup release-plan and we can look at getting a release out 👍 |
dgavey
approved these changes
Apr 15, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran ember init -b @embroider/addon-blueprint@latest --pnpm and moved things around a bit.
One thing I did notice wasn't working is the Ember Data integration, but that is probably more related to the changes in Ember Data recently🙈
This PR was originally opened to mharris717/ember-drag-drop#218 but we've moved it to adopted-ember-addons 👍