Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update @embroider/test-setup to fix CI #749

Merged
merged 2 commits into from
Feb 26, 2024
Merged

update @embroider/test-setup to fix CI #749

merged 2 commits into from
Feb 26, 2024

Conversation

mansona
Copy link
Contributor

@mansona mansona commented Nov 8, 2023

The @embroider/test-setup package was very out of date so we really couldn't expect the embroider-safe or embroider-optimised tests to pass without updating it 👍

@mansona mansona force-pushed the fix-embroider branch 2 times, most recently from e72c267 to 3db27c6 Compare November 9, 2023 16:46
@mansona
Copy link
Contributor Author

mansona commented Nov 9, 2023

Using @Pixelik's suggestion in #733 (comment) brings the failing tests down from 9 to 5 which is progress I guess 🤷

@mansona mansona merged commit 8eb46e8 into main Feb 26, 2024
10 of 13 checks passed
@github-actions github-actions bot mentioned this pull request Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant