Fix CI builds #664
Closed
Fix CI builds #664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ember 3.13 and above are no longer supporting Node.js 6, but since this project still supports it and dropping support would be a breaking change we need to adjust our CI pipeline to use Node.js 8 instead for the ember-try scenarios that need it.
... which still supports Node.js 6 see poetic/ember-cli-github-pages@aa46772#r34236099
... which still supports Node.js 6 see ef4/ember-code-snippet#60 (comment)
... which still supports Node.js 6 see sass/dart-sass@d0f471c#commitcomment-35247983
... which still supports Node.js 6
as suggested in their documentation
|
Originally this PR was only about using the correct Node.js version per Ember.js release but it turned out that a lot of other things were also broken. The PR now also pins a few dependencies to specific versions where Node.js 6 is still supported and it fixes a broken prettier check. Hopefully CI should be 🍏 now after all these changes. |
... which still supports Node.js 6 see socketio/engine.io#589
|
It looks like the only things that are now legitimately failing CI are the changes in Ember 3.13 like:
Those are addressed by #662 AFAIK |
|
closed in favor of #667 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ember 3.13 and above are no longer supporting Node.js 6, but since this project still supports it and dropping support would be a breaking change we need to adjust our CI pipeline to use Node.js 8 instead for the ember-try scenarios that need it.
(as suggested in #662 (comment))
/cc @GavinJoyce @rwjblue @offirgolan