[SPIKE] try Ember 3.13.0-beta.4 #657
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I skipped one test that's failing in 3.11+: #656 |
|
There are some linting rules which are failing, but the tests are passing on CI:
|
GavinJoyce
force-pushed
the
gj/ember-3.13-beta
branch
from
b9d6b66
to
07f288c
Compare
GavinJoyce
commented
Aug 27, 2019
| @@ -1040,7 +1040,7 @@ module('Integration | Validations | Factory - General', function(hooks) { | |||
| assert.equal(child.get('validations.errors.length'), 1); | |||
| }); | |||
|
|
|||
| test('call super in validations class with no super property', function(assert) { | |||
| skip('call super in validations class with no super property', function(assert) { | |||
There was a problem hiding this comment.
this is also failing in Ember 3.11: #656
|
superseded by #662 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seems to be a number of failing test seemingly caused by
getDependentKeysreturningnull.3.12.0:
3.13.0-beta.4: