Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update addon to Ember CLI 3.12 #654

Conversation

patocallaghan
Copy link

This is a follow on to my PR at #653. It appears CI is failing due to a node 6 engine incompatibility issue.

Seeing as we're currently in a 4.x beta period it's probably worth upgrading the addon to ember-cli 3.12 which also drops Node 6 support.

@patocallaghan
Copy link
Author

A single test fails in CI: Integration | Validations | Factory - General: call super in validations class with no super property

The error being:

Error: Assertion Failed: An EmberObject based class, (unknown), was not instantiated correctly. You may have either used new instead of .create(), or not passed arguments to your call to super in the constructor: super(...arguments). If you are trying to use new, consider using native classes without extending from EmberObject.

This failing test is unrelated to this PR as this has been failing since 3.11. There's an already an issue for it in #642

@offirgolan
Copy link
Collaborator

Closing in favor of #668.

@offirgolan offirgolan closed this Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants