Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes action handling #34

Merged
merged 1 commit into from
Apr 9, 2017
Merged

Fixes action handling #34

merged 1 commit into from
Apr 9, 2017

Conversation

MiguelMadero
Copy link
Collaborator

@MiguelMadero MiguelMadero commented Nov 20, 2016 •
edited
Loading

Fixes #27

@MiguelMadero MiguelMadero mentioned this pull request Nov 20, 2016
Closed
@MiguelMadero MiguelMadero changed the title Fixes https://github.com/toranb/ember-cli-hot-loader/issues/27 Fixes action handling Nov 20, 2016
@MiguelMadero
Copy link
Collaborator Author

targetObject was private in 2.7 and looks like it was removed either in 2.8 or 2.9. Travis failed for 2.9, beta and canary and I verified locally that 2.9.1 doesn't work. I'll leave the PR and this branch in case someone has some time to find an alternative or if the branch helps for someone working in an old version of Ember. I'll focus on the AST branch next week.

@MiguelMadero MiguelMadero force-pushed the mmadero/fixes-classic-actions branch 2 times, most recently from 1eef6d6 to 4fb7651 Compare November 21, 2016 03:16
This was referenced Nov 21, 2016
Closed
Merged
@MiguelMadero
Copy link
Collaborator Author

I made some good progress on the AST branch. I'll pull the tests for actions from this PR to make sure it works on #25

@MiguelMadero
Copy link
Collaborator Author

MiguelMadero commented Mar 3, 2017 •
edited
Loading

Retriggering builds. This was the previous status 3 months ago:

image

@MiguelMadero
Sets the _targetObject on the wrapped component to the wrapper’s targ…
6058f5a 
…etObject so actions work correctly.

Fix: action handling
@MiguelMadero MiguelMadero force-pushed the mmadero/fixes-classic-actions branch from 4fb7651 to 6058f5a Compare March 3, 2017 03:00
@MiguelMadero
Copy link
Collaborator Author

@oligriffiths just rebased and triggered a new build to see if it makes any difference with the latest versions. I'm not sure if the previous run had the fix for emberjs/ember.js#14168 already

@MiguelMadero
Copy link
Collaborator Author

@oligriffiths the tests passed, but we would have to manually verify that it actually hot-reloads since we don't have end to end test automation yet :(
Can you have a look? Otherwise I could give it a shot early next week.

@MiguelMadero
Copy link
Collaborator Author

Can you have a look? Otherwise I could give it a shot early next week.

And early next week, just became early next month :) I'm having a look now

@oligriffiths
Copy link
Contributor

@MiguelMadero awesome, watching intently

@MiguelMadero
Copy link
Collaborator Author

Verified manually in 2.7.3, ember-1.13 and ember-release. We're good to merge, sorry for the delay on this.

@MiguelMadero MiguelMadero merged commit d910619 into master Apr 9, 2017
@MiguelMadero MiguelMadero deleted the mmadero/fixes-classic-actions branch April 9, 2017 02:05
@MiguelMadero
Copy link
Collaborator Author

Released as v0.1.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MiguelMadero @oligriffiths