chore(app): remove debug console.log in terminal WebSocket #25
Conversation
- Add image compression when clipboard images exceed 4MB (API limit is 5MB) - Use ImageMagick for progressive compression (quality 85→30, resize 100%→25%) - Convert oversized PNGs to optimized JPEGs - Graceful fallback if ImageMagick unavailable fix(provider): allow instructions param for Codex API - Add "instructions" to OpenAI supported params whitelist - Fixes "Instructions are required" error with gpt-5.2-codex Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Remove development debug logging for WebSocket connect/disconnect events.
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5b52c5692c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // Exit codes: 0 = matches found, 1 = no matches, 2 = errors (but may still have matches) | ||
| // With --no-messages, we suppress error output but still get exit code 2 for broken symlinks etc. | ||
| // Only fail if exit code is 2 AND no output was produced | ||
| if (exitCode === 1 || (exitCode === 2 && !output.trim())) { |
There was a problem hiding this comment.
Because --no-messages only suppresses file-open errors and “error messages related to the syntax of the pattern are still shown” (rg --help), invalid regexes (or other rg errors) can produce no stdout but do emit stderr. With the new branch that treats exitCode === 2 and empty stdout as “No files found,” those syntax errors are silently reported as zero matches, which misleads users and prevents them from fixing the pattern. Consider checking errorOutput when exitCode === 2 and returning an error message instead of a successful no‑matches result.
Useful? React with 👍 / 👎.
Remove development debug logging for WebSocket connect/disconnect events in the terminal component.