Skip to content

fix(field-label): address edge case where required icon would not render on the same line(Safari only) #5822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

fix(field-label): address edge case where required icon would not render on the same line(Safari only) #5822

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b7ec06a
fix(field-label): prevent the asterisk on required field labels from …
cdransf Nov 5, 2025
03ce2a3
fix(field-label): remove margin from required asterisk
cdransf Nov 5, 2025
64ad19b
fix(field-label): replace nbsp with thinsp
cdransf Nov 6, 2025
03e3c57
fix(field-label): replace nbsp with narrow no break space
cdransf Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions 1st-gen/packages/field-label/src/FieldLabel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,9 +153,12 @@ export class FieldLabel extends SizedMixin(SpectrumElement, {
<slot></slot>
${this.required
? html`
<sp-icon-asterisk100
class="required-icon spectrum-UIIcon-Asterisk100"
></sp-icon-asterisk100>
<span>
&#8239;
<sp-icon-asterisk100
class="required-icon spectrum-UIIcon-Asterisk100"
></sp-icon-asterisk100>
</span>
`
: nothing}
</label>
Expand Down
1 change: 0 additions & 1 deletion 1st-gen/packages/field-label/src/spectrum-field-label.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,6 @@
.required-icon {
color: inherit;
margin-block: 0;
margin-inline: var(--mod-field-label-text-to-asterisk, var(--spectrum-field-label-text-to-asterisk)) 0;
vertical-align: initial;
vertical-align: var(--mod-field-label-asterisk-vertical-align, baseline);
}
Expand Down
Loading