Skip to content

chore(deps): pin package dependencies in 2nd-gen #5820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2025
+108 −108
Merged

chore(deps): pin package dependencies in 2nd-gen #5820

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion second-gen/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"packages/*"
],
"devDependencies": {
"eslint-plugin-simple-import-sort": "^12.1.1"
"eslint-plugin-simple-import-sort": "12.1.1"
},
"keywords": [
"design-system",
Expand Down
10 changes: 5 additions & 5 deletions second-gen/packages/core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,11 +47,11 @@
"lit": "^2.5.0 || ^3.1.3"
},
"devDependencies": {
"glob": "^11.0.0",
"rimraf": "^6.0.1",
"typescript": "^5.3.3",
"vite": "^7.1.3",
"vite-plugin-dts": "^4.3.0"
"glob": "11.0.3",
"rimraf": "6.0.1",
"typescript": "5.9.2",
"vite": "7.1.7",
"vite-plugin-dts": "4.5.4"
},
"keywords": [
"design-system",
Expand Down
44 changes: 22 additions & 22 deletions second-gen/packages/swc/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,33 +49,33 @@
"lit": "^2.5.0 || ^3.1.3"
},
"devDependencies": {
"@axe-core/playwright": "^4.10.2",
"@custom-elements-manifest/analyzer": "^0.10.5",
"@axe-core/playwright": "4.10.2",
"@custom-elements-manifest/analyzer": "0.10.8",
"@storybook/addon-a11y": "9.1.10",
"@storybook/addon-designs": "10.0.2",
"@storybook/addon-docs": "9.1.10",
"@storybook/addon-vitest": "^9.1.10",
"@storybook/test-runner": "^0.23.0",
"@storybook/addon-vitest": "9.1.10",
"@storybook/test-runner": "0.23.0",
"@storybook/web-components-vite": "9.1.10",
"@types/react": "^19",
"@types/react-dom": "^19",
"@vitest/browser": "^3.2.4",
"@types/react": "19.1.16",
"@types/react-dom": "19.1.9",
Comment on lines +60 to +61
Copy link
Contributor

@Rajdeepc Rajdeepc Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason behind bumping "@types/react": "19.1.16" and not to 19.1.1? Shouldn't be a problem though if the ts build passes.

Copy link
Contributor Author

@rubencarvalho rubencarvalho Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was the previously resolved version, so nothing changed here! :)

Screenshot 2025-10-23 at 22 20 02

"@vitest/browser": "3.2.4",
"@vitest/coverage-v8": "3.2.4",
"@vitest/ui": "^3.2.4",
"@wc-toolkit/storybook-helpers": "^9.0.1",
"autoprefixer": "^10.4.21",
"glob": "^11.0.0",
"playwright": "^1.55.0",
"postcss": "^8.5.6",
"postcss-preset-env": "^10.3.1",
"react": "^19.1.1",
"react-dom": "^19.1.1",
"rimraf": "^6.0.1",
"storybook": "^9.1.10",
"typescript": "^5.3.3",
"vite": "^7.1.3",
"vite-plugin-dts": "^4.3.0",
"vite-plugin-lit-css": "^2.2.1",
"@vitest/ui": "3.2.4",
"@wc-toolkit/storybook-helpers": "9.0.1",
"autoprefixer": "10.4.21",
"glob": "11.0.3",
"playwright": "1.53.1",
Copy link
Contributor

@caseyisonit caseyisonit Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is resolving to the version needed in first-gen… I’m ok with keeping parity for now but wanted to flag this.

Copy link
Contributor Author

@rubencarvalho rubencarvalho Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call. I think keeping parity is good for now.

Copy link
Contributor Author

@rubencarvalho rubencarvalho Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But FYI, we already had

"resolutions": {
        "playwright": "1.53.1"
    },

"postcss": "8.5.6",
"postcss-preset-env": "10.4.0",
"react": "19.1.1",
"react-dom": "19.1.1",
"rimraf": "6.0.1",
"storybook": "9.1.10",
"typescript": "5.9.2",
Copy link
Contributor

@Rajdeepc Rajdeepc Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change needs a full TS build to check for regression. Laying this out here for other reviewers

"vite": "7.1.7",
"vite-plugin-dts": "4.5.4",
"vite-plugin-lit-css": "2.2.1",
"vitest": "3.2.4"
},
"keywords": [
Expand Down
Loading
Loading