feat: introduce navigation and traffic acquisition data in form audit

adobe · Jan 25, 2025 · 2e2b44e · 2e2b44e
1 parent c0a70b9
commit 2e2b44e
Show file tree

Hide file tree

Showing 3 changed files with 37 additions and 8 deletions.
diff --git a/packages/spacecat-shared-rum-api-client/src/functions/form-vitals.js b/packages/spacecat-shared-rum-api-client/src/functions/form-vitals.js
@@ -91,13 +91,11 @@ function findFormCTAForInternalNavigation(bundles, formVitals) {
           });
 
           // Convert CTAs Map to an array and store it in the nav object
-          return {
-            ...nav,
-            CTAs: Array.from(CTAs.values()),
-            totalClickOnPage,
-          };
+          // eslint-disable-next-line no-param-reassign
+          nav.CTAs = Array.from(CTAs.values());
+          // eslint-disable-next-line no-param-reassign
+          nav.totalClicksOnPage = totalClickOnPage;
         }
-        return nav;
       });
     }
   });

diff --git a/packages/spacecat-shared-rum-api-client/test/fixtures/bundles-for-form-vitals.json b/packages/spacecat-shared-rum-api-client/test/fixtures/bundles-for-form-vitals.json
@@ -61375,6 +61375,30 @@
         }
       ]
     },
+    {
+      "id": "fx4g",
+      "host": "rum.hlx.page",
+      "time": "2024-10-29T08:00:00.865Z",
+      "timeSlot": "2024-10-29T08:00:00.000Z",
+      "url": "https://business.adobe.com/products/marketo.html",
+      "userAgent": "desktop:linux",
+      "weight": 100,
+      "events": [
+        {
+          "checkpoint": "click",
+          "source": "#tab-features-2",
+          "target": "https://business.adobe.com/jp/products/magento/magento-commerce.html"
+        },
+        {
+          "checkpoint": "viewblock",
+          "timeDelta": 883
+        },
+        {
+          "checkpoint": "viewblock",
+          "timeDelta": 882
+        }
+      ]
+    },
     {
       "id": "g3jr",
       "host": "rum.hlx.page",

diff --git a/packages/spacecat-shared-rum-api-client/test/fixtures/expected-form-vitals-result.json b/packages/spacecat-shared-rum-api-client/test/fixtures/expected-form-vitals-result.json
@@ -16,12 +16,19 @@
       {
         "url": "https://business.adobe.com/products/marketo.html",
         "pageview": {
-          "desktop:linux": 1900,
+          "desktop:linux": 2000,
           "desktop:mac": 1300,
           "desktop:windows": 1200,
           "mobile:android": 300,
           "mobile:ios": 200
-        }
+        },
+        "CTAs": [
+          {
+            "source": "#tab-features-2",
+            "clicks": 100
+          }
+        ],
+        "totalClicksOnPage": 800
       }
     ],
     "trafficacquisition": {