feat: changes to accomodate new config data model #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me I think it can be merged after the config |
…into new-data-model Incorporating the latest changes from main branch.
|
This PR will trigger a minor release when merged. |
alinarublea
changed the title
iuliag
approved these changes
Jul 16, 2024
|
|
||
| const excludedURLs = auditConfig.getAuditTypeConfig(type)?.getExcludedURLs(); | ||
| const excludedURLs = site.getConfig().getExcludedURLs(type); | ||
| // const excludedURLs = auditConfig.getAuditTypeConfig(type)?.getExcludedURLs(); |
There was a problem hiding this comment.
The commented code should be cleaned-up at the end
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please ensure your pull request adheres to the following guidelines:
Related Issues
Thanks for contributing!