docs: fix scroll position restoration when navigating back/forward #9242
+57
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! 🎉 |
LFDanLu
approved these changes
Nov 25, 2025
Member
LFDanLu
left a comment
LFDanLu
left a comment
There was a problem hiding this comment.
Seems to work well, bit unfortunate that we have to do this manually though
devongovett
reviewed
Nov 26, 2025
| let currentAbortController: AbortController | null = null; | ||
|
|
||
| // Store scroll positions by pathname | ||
| const scrollPositions = new Map<string, {scrollTop: number, windowScrollTop: number}>(); |
Member
There was a problem hiding this comment.
Maybe we can save these in the history entry itself? https://stackoverflow.com/a/16732655
Might also have to turn off the browser's defaults? https://developer.chrome.com/blog/history-api-scroll-restoration
I did wonder if the defaults would work if we moved the key from the <main> element further down (e.g. article) so that it doesn't get replaced on each navigation. Did you try that?
| if (scrollContainer) { | ||
| scrollContainer.scrollTop = position.scrollTop; | ||
| } | ||
| window.scrollTo(0, position.windowScrollTop); |
Member
There was a problem hiding this comment.
Wouldn't it need to be the inner div that we scroll not the window?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to handle this manually since we're using the scrollable container instead of the window.
✅ Pull Request Checklist:
📝 Test Instructions:
Verify that scroll position is restored when navigating back/forward in the browser. Also verify that scroll positions are still accurate for hash links.
🧢 Your Project: