Skip to content

Conversation

@devongovett
Copy link
Member

@devongovett devongovett commented Nov 19, 2025

  • Updates line widths to be narrower (but images/videos stay wide) for improved readability of long form content (e.g. blog)
  • Reduces font size of h2
  • Improves spacing between paragraphs/headings
  • Improves text wrapping
  • Adds back table of contents to blog and releases
  • Increases total layout maximum width so there is more space around article
  • Adds some structured data for SEO
  • Adds RSS feeds to blog/releases

@rspbot
Copy link

rspbot commented Nov 19, 2025

Copy link
Member

@snowystinger snowystinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not as big a fan on the home pages
Image

Maybe we can keep the sidenav on the blog pages now too?
I feel a little detached without it
Image

For headings, can we use text-wrap-style: balance; I think it looks better, at least on https://reactspectrum.blob.core.windows.net/reactspectrum/937a80cfe85fec86562b960e18fbfcca021ae798/s2-docs/react-aria/blog/rtl-date-time.html
Including the H2 below it.
That, or should we use I18N instead of internationalization?

@devongovett
Copy link
Member Author

ah yeah it wasn't supposed to apply to the home pages, just blog/releases.

@rspbot
Copy link

rspbot commented Nov 23, 2025

@rspbot
Copy link

rspbot commented Nov 23, 2025

@rspbot
Copy link

rspbot commented Nov 24, 2025

@devongovett devongovett marked this pull request as ready for review November 24, 2025 18:08
@rspbot
Copy link

rspbot commented Nov 24, 2025

@rspbot
Copy link

rspbot commented Nov 24, 2025

## API Changes

@react-spectrum/s2

/@react-spectrum/s2:Heading

 Heading {
   UNSAFE_className?: UnsafeClassName
   UNSAFE_style?: CSSProperties
   children: ReactNode
   id?: string
   isHidden?: boolean
+  itemID?: string
+  itemProp?: string
+  itemRef?: string
+  itemScope?: boolean
+  itemType?: string
   level?: number
   slot?: string | null
   styles?: StyleString
 }

/@react-spectrum/s2:Header

 Header {
   UNSAFE_className?: UnsafeClassName
   UNSAFE_style?: CSSProperties
   children: ReactNode
   id?: string
   isHidden?: boolean
+  itemID?: string
+  itemProp?: string
+  itemRef?: string
+  itemScope?: boolean
+  itemType?: string
   slot?: string | null
   styles?: StyleString
 }

/@react-spectrum/s2:Content

 Content {
   UNSAFE_className?: UnsafeClassName
   UNSAFE_style?: CSSProperties
   children: ReactNode
   id?: string
   isHidden?: boolean
+  itemID?: string
+  itemProp?: string
+  itemRef?: string
+  itemScope?: boolean
+  itemType?: string
   slot?: string | null
   styles?: StyleString
 }

/@react-spectrum/s2:Footer

 Footer {
   UNSAFE_className?: UnsafeClassName
   UNSAFE_style?: CSSProperties
   children: ReactNode
   id?: string
   isHidden?: boolean
+  itemID?: string
+  itemProp?: string
+  itemRef?: string
+  itemScope?: boolean
+  itemType?: string
   slot?: string | null
   styles?: StyleString
 }

/@react-spectrum/s2:Text

 Text {
   UNSAFE_className?: UnsafeClassName
   UNSAFE_style?: CSSProperties
   children: ReactNode
   id?: string
   isHidden?: boolean
+  itemID?: string
+  itemProp?: string
+  itemRef?: string
+  itemScope?: boolean
+  itemType?: string
   slot?: string | null
   styles?: StyleString
 }

/@react-spectrum/s2:Keyboard

 Keyboard {
   UNSAFE_className?: UnsafeClassName
   UNSAFE_style?: CSSProperties
   children: ReactNode
   id?: string
   isHidden?: boolean
+  itemID?: string
+  itemProp?: string
+  itemRef?: string
+  itemScope?: boolean
+  itemType?: string
   slot?: string | null
   styles?: StyleString
 }

Copy link
Member

@LFDanLu LFDanLu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, my only nit would be that going from the "Releases" index page into a actual release page has quite the shift in where the text starts (not as noticeable as on the blogs) but thats quite minor

@devongovett
Copy link
Member Author

Yeah that was something I noticed too. Happens whenever the TOC is present on one page and not another as well. Could be an argument for left aligning instead of center aligning? 🤷

@LFDanLu LFDanLu added this pull request to the merge queue Nov 24, 2025
Merged via the queue into main with commit ef3ff3d Nov 24, 2025
32 checks passed
@LFDanLu LFDanLu deleted the typography branch November 24, 2025 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants