-
Notifications
You must be signed in to change notification settings - Fork 1.4k
docs: Refine typography #9216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Refine typography #9216
Conversation
|
Build successful! 🎉 |
snowystinger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not as big a fan on the home pages

Maybe we can keep the sidenav on the blog pages now too?
I feel a little detached without it

For headings, can we use text-wrap-style: balance; I think it looks better, at least on https://reactspectrum.blob.core.windows.net/reactspectrum/937a80cfe85fec86562b960e18fbfcca021ae798/s2-docs/react-aria/blog/rtl-date-time.html
Including the H2 below it.
That, or should we use I18N instead of internationalization?
|
ah yeah it wasn't supposed to apply to the home pages, just blog/releases. |
# Conflicts: # packages/dev/s2-docs/src/Layout.tsx
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
## API Changes
@react-spectrum/s2/@react-spectrum/s2:Heading Heading {
UNSAFE_className?: UnsafeClassName
UNSAFE_style?: CSSProperties
children: ReactNode
id?: string
isHidden?: boolean
+ itemID?: string
+ itemProp?: string
+ itemRef?: string
+ itemScope?: boolean
+ itemType?: string
level?: number
slot?: string | null
styles?: StyleString
}/@react-spectrum/s2:Header Header {
UNSAFE_className?: UnsafeClassName
UNSAFE_style?: CSSProperties
children: ReactNode
id?: string
isHidden?: boolean
+ itemID?: string
+ itemProp?: string
+ itemRef?: string
+ itemScope?: boolean
+ itemType?: string
slot?: string | null
styles?: StyleString
}/@react-spectrum/s2:Content Content {
UNSAFE_className?: UnsafeClassName
UNSAFE_style?: CSSProperties
children: ReactNode
id?: string
isHidden?: boolean
+ itemID?: string
+ itemProp?: string
+ itemRef?: string
+ itemScope?: boolean
+ itemType?: string
slot?: string | null
styles?: StyleString
}/@react-spectrum/s2:Footer Footer {
UNSAFE_className?: UnsafeClassName
UNSAFE_style?: CSSProperties
children: ReactNode
id?: string
isHidden?: boolean
+ itemID?: string
+ itemProp?: string
+ itemRef?: string
+ itemScope?: boolean
+ itemType?: string
slot?: string | null
styles?: StyleString
}/@react-spectrum/s2:Text Text {
UNSAFE_className?: UnsafeClassName
UNSAFE_style?: CSSProperties
children: ReactNode
id?: string
isHidden?: boolean
+ itemID?: string
+ itemProp?: string
+ itemRef?: string
+ itemScope?: boolean
+ itemType?: string
slot?: string | null
styles?: StyleString
}/@react-spectrum/s2:Keyboard Keyboard {
UNSAFE_className?: UnsafeClassName
UNSAFE_style?: CSSProperties
children: ReactNode
id?: string
isHidden?: boolean
+ itemID?: string
+ itemProp?: string
+ itemRef?: string
+ itemScope?: boolean
+ itemType?: string
slot?: string | null
styles?: StyleString
} |
LFDanLu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, my only nit would be that going from the "Releases" index page into a actual release page has quite the shift in where the text starts (not as noticeable as on the blogs) but thats quite minor
|
Yeah that was something I noticed too. Happens whenever the TOC is present on one page and not another as well. Could be an argument for left aligning instead of center aligning? 🤷 |
Uh oh!
There was an error while loading. Please reload this page.