fix: use client in s2 icons #9153
Merged
+948
−940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! 🎉 |
reidbarber
approved these changes
Nov 5, 2025
LFDanLu
reviewed
Nov 6, 2025
Comment on lines
+2
to
+9
| const glob = require('glob'); | ||
|
|
||
| let iconFiles = glob.sync('packages/@react-spectrum/s2/{icons,illustrations}/**/*.{cjs,mjs}'); | ||
| for (let f of iconFiles) { | ||
| let contents = fs.readFileSync(f, 'utf8'); | ||
| contents = contents.replace(/['"]use client['"];?/g, ''); | ||
| fs.writeFileSync(f, contents); | ||
| } |
Member
There was a problem hiding this comment.
wait so is it a problem if we remove the use client from the icons? #9126 (comment) seems to indicate that they should be client components but I'm not quite familiar with the nature of the nextJS build issue
Member
Author
There was a problem hiding this comment.
yeah, so it's supported in our docs, which build from src. but it's not supported outside of that yet, so we just remove it, that's why it's removed from the other two files in this script as well, external users must import s2 components in a file that already has use client
don't worry, I asked the same questions when chatting with Devon about how to fix this
Member
There was a problem hiding this comment.
gotcha, thanks for the explanation
LFDanLu
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: