Skip to content

Don't waste a number formatter #9128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
+1 −1
Closed

Don't waste a number formatter #9128

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/@react-aria/progress/src/useProgressBar.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,9 @@ export function useProgressBar(props: AriaProgressBarProps): ProgressBarAria {

value = clamp(value, minValue, maxValue);
let percentage = (value - minValue) / (maxValue - minValue);
let formatter = useNumberFormatter(formatOptions);

if (!isIndeterminate && !valueLabel) {
let formatter = useNumberFormatter(formatOptions);
Copy link
Member

@snowystinger snowystinger Nov 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This unfortunately breaks the rules of hooks. However, within useNumberFormatter we do cache them, so over the lifetime of an app, the expense should become less.

Copy link
Author

@plesiecki plesiecki Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point about the rules of hooks. Whether cached or not, it's still suboptimal and can block the main thread unnecessarily.

Copy link
Member

@snowystinger snowystinger Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you running into an issue with it in your application? or is this hypothetical?
there are ways to write this so that the rules of hooks aren't broken, but I'd like to know more information

let valueToFormat = formatOptions.style === 'percent' ? percentage : value;
valueLabel = formatter.format(valueToFormat);
}
Expand Down