-
Notifications
You must be signed in to change notification settings - Fork 1.3k
docs: fix og images and descriptions #8990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+287
−174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build successful! 🎉 |
Build successful! 🎉 |
Build successful! 🎉 |
Build successful! 🎉 |
Build successful! 🎉 |
Build successful! 🎉 |
Build successful! 🎉 |
Build successful! 🎉 |
LFDanLu
previously approved these changes
Oct 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build successful! 🎉 |
Build successful! 🎉 |
LFDanLu
approved these changes
Oct 9, 2025
Build successful! 🎉 |
snowystinger
approved these changes
Oct 9, 2025
LFDanLu
pushed a commit
that referenced
this pull request
Oct 9, 2025
* fix og:image links * fix font in SVG rendering * make logo dynamic * more name aliases for illustrations * Revert "fix font in SVG rendering" This reverts commit dd53fbc. * try inlining fonts in svg * Revert "try inlining fonts in svg" This reverts commit 8b3fa87. * generate images for index pages * generate images for pages without illustrations * try installing fonts in CI * switch fonts * remove font install from CI * try inlining font-face and pre-rendering illustration as png * Revert "try inlining font-face and pre-rendering illustration as png" This reverts commit 5b6c002. * try using fontconfig in CI * update command * more CI updates * strip out version badge from title * remove illustration SVGs for now * improve gap * layout improvements * skip error page * add Internationalized to library in name * fix page title in Internationalized * improve titles and descriptions * improve titles for index pages and explicit custom titles
devongovett
pushed a commit
that referenced
this pull request
Oct 9, 2025
* fix og:image links * fix font in SVG rendering * make logo dynamic * more name aliases for illustrations * Revert "fix font in SVG rendering" This reverts commit dd53fbc. * try inlining fonts in svg * Revert "try inlining fonts in svg" This reverts commit 8b3fa87. * generate images for index pages * generate images for pages without illustrations * try installing fonts in CI * switch fonts * remove font install from CI * try inlining font-face and pre-rendering illustration as png * Revert "try inlining font-face and pre-rendering illustration as png" This reverts commit 5b6c002. * try using fontconfig in CI * update command * more CI updates * strip out version badge from title * remove illustration SVGs for now * improve gap * layout improvements * skip error page * add Internationalized to library in name * fix page title in Internationalized * improve titles and descriptions * improve titles for index pages and explicit custom titles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
og:image
linksI removed the illustration SVGs due to clipping and text rendering issues (and we're also still missing a bunch). We can bring this back at a later date.
✅ Pull Request Checklist:
📝 Test Instructions:
Paste build links into a site like https://www.opengraph.xyz/ to check images.
🧢 Your Project: