Skip to content

Conversation

reidbarber
Copy link
Member

@reidbarber reidbarber commented Oct 7, 2025

  • Fixes og:image links
  • Adds images for all pages (including index pages)
  • Fixed page titles for Internationalized pages
  • Improved page descriptions

I removed the illustration SVGs due to clipping and text rendering issues (and we're also still missing a bunch). We can bring this back at a later date.

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Paste build links into a site like https://www.opengraph.xyz/ to check images.

🧢 Your Project:

@rspbot
Copy link

rspbot commented Oct 7, 2025

@reidbarber reidbarber changed the title docs: fix og images WIP: docs: fix og images Oct 7, 2025
@rspbot
Copy link

rspbot commented Oct 7, 2025

@rspbot
Copy link

rspbot commented Oct 7, 2025

@rspbot
Copy link

rspbot commented Oct 7, 2025

@rspbot
Copy link

rspbot commented Oct 8, 2025

@reidbarber reidbarber changed the title WIP: docs: fix og images docs: fix og images Oct 9, 2025
@rspbot
Copy link

rspbot commented Oct 9, 2025

@rspbot
Copy link

rspbot commented Oct 9, 2025

@rspbot
Copy link

rspbot commented Oct 9, 2025

LFDanLu
LFDanLu previously approved these changes Oct 9, 2025
Copy link
Member

@LFDanLu LFDanLu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, noticed that the intro pages for React Spectrum/React Aria preview descriptions follow the same template as for other pages, aka "Documentation for ___"
image
which is kinda odd but can be handled in a followup

@rspbot
Copy link

rspbot commented Oct 9, 2025

@reidbarber reidbarber changed the title docs: fix og images docs: fix og images and descriptions Oct 9, 2025
@rspbot
Copy link

rspbot commented Oct 9, 2025

@rspbot
Copy link

rspbot commented Oct 9, 2025

@reidbarber reidbarber added this pull request to the merge queue Oct 9, 2025
Merged via the queue into main with commit a146a50 Oct 9, 2025
32 checks passed
@reidbarber reidbarber deleted the fix-og-images branch October 9, 2025 21:39
LFDanLu pushed a commit that referenced this pull request Oct 9, 2025
* fix og:image links

* fix font in SVG rendering

* make logo dynamic

* more name aliases for illustrations

* Revert "fix font in SVG rendering"

This reverts commit dd53fbc.

* try inlining fonts in svg

* Revert "try inlining fonts in svg"

This reverts commit 8b3fa87.

* generate images for index pages

* generate images for pages without illustrations

* try installing fonts in CI

* switch fonts

* remove font install from CI

* try inlining font-face and pre-rendering illustration as png

* Revert "try inlining font-face and pre-rendering illustration as png"

This reverts commit 5b6c002.

* try using fontconfig in CI

* update command

* more CI updates

* strip out version badge from title

* remove illustration SVGs for now

* improve gap

* layout improvements

* skip error page

* add Internationalized to library in name

* fix page title in Internationalized

* improve titles and descriptions

* improve titles for index pages and explicit custom titles
devongovett pushed a commit that referenced this pull request Oct 9, 2025
* fix og:image links

* fix font in SVG rendering

* make logo dynamic

* more name aliases for illustrations

* Revert "fix font in SVG rendering"

This reverts commit dd53fbc.

* try inlining fonts in svg

* Revert "try inlining fonts in svg"

This reverts commit 8b3fa87.

* generate images for index pages

* generate images for pages without illustrations

* try installing fonts in CI

* switch fonts

* remove font install from CI

* try inlining font-face and pre-rendering illustration as png

* Revert "try inlining font-face and pre-rendering illustration as png"

This reverts commit 5b6c002.

* try using fontconfig in CI

* update command

* more CI updates

* strip out version badge from title

* remove illustration SVGs for now

* improve gap

* layout improvements

* skip error page

* add Internationalized to library in name

* fix page title in Internationalized

* improve titles and descriptions

* improve titles for index pages and explicit custom titles
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants