Fix ListBox typeahead spacebar issue #869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solimant
requested review from
dannify,
devongovett and
snowystinger
as code owners
solimant
force-pushed
the
RSP-1828
branch
2 times, most recently
from
a169e36
to
39d7de0
Compare
| @@ -489,6 +493,34 @@ describe('ListBox', function () { | |||
| expect(document.activeElement).toBe(options[4]); | |||
| }); | |||
|
|
|||
| it('supports the space character in a search', function () { | |||
There was a problem hiding this comment.
if you use jest.useFakeTimers, you can step through time to verify that you can use space bar to select the option after the typeahead timeout has completed, i won't require that you write that test, just an interesting thing you can do
There was a problem hiding this comment.
Thanks, @snowystinger, good idea! I called it out in the test instructions, so I think I should include it as well as a test.
| @@ -88,6 +99,8 @@ function getStringForKey(key: string) { | |||
| // See https://www.w3.org/TR/uievents-key/ | |||
| if (key.length === 1 || !/^[A-Z]/i.test(key)) { | |||
| return key; | |||
| } else if (key === 'Spacebar') { // For IE 11 | |||
There was a problem hiding this comment.
we don't care about IE 11 anymore if you want to remove this, no sense in dead code :)
snowystinger
approved these changes
Aug 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #851
✅ Pull Request Checklist:
📝 Test Instructions:
Section 8🧢 Your Project:
Adobe React-Spectrum
