-
Notifications
You must be signed in to change notification settings - Fork 1.3k
fix: Support React Suspense in collections #7912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, tested in macos chrome/ff/safari
|
@devongovett thank you! Any idea when this will be released? |
571b46e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Table story seems to behave properly with reactTransition turned on/off, approving for further testing
|
Is there a way to use this now? |
|
@Danieljs-codes you should be able to use the nightly to get this fix |
|
@yihuiliao how should one install it? |
|
The nightly is an exact version, all dependencies you use from our libraries should point to the same nightly version. That is says '3.anything' is irrelevant and more has to do with ease of tracking the same nightly across the entire repo where our first packages happened to be 3.0's for legacy reasons.
|
|
@snowystinger thanks for the clarification! Would it be ok to include this info somewhere in the readme? |
Fixes #6182, fixes #7535
There were two issues with our collection implementation with Suspense:
display: noneon items inside a suspense boundary, while the fallback is visible. We didn't implement this, so it resulted in the loading indicator being displayed alongside the existing items rather than replacing them. I fixed this by tracking whether an element is hidden. Hidden elements are kept in our fake DOM, but they are removed from the collection.