chore: revert export provider context #7416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snowystinger
changed the title
devongovett
reviewed
Nov 21, 2024
| @@ -341,7 +341,7 @@ describe('ColorWheel', () => { | |||
| let defaultColor = parseColor('hsl(0, 100%, 50%)'); | |||
| let {container: _container, getByRole} = render(<ControlledHSL defaultValue={defaultColor} onChange={onChangeSpy} onChangeEnd={onChangeEndSpy} />); | |||
| let slider = getByRole('slider'); | |||
| let container = _container?.firstChild?.firstChild?.firstChild as HTMLElement; | |||
| let container = _container?.firstChild?.firstChild?.firstChild?.firstChild as HTMLElement; | |||
There was a problem hiding this comment.
yeah... we have far too many of these, they are very silly
devongovett
reviewed
Nov 21, 2024
| @@ -34,3 +37,7 @@ function customRender(ui, options) { | |||
|
|
|||
| // override render method with | |||
| export {customRender as render}; | |||
|
|
|||
| export function renderv3(ui, options, providerProps) { | |||
There was a problem hiding this comment.
just confirming: this isn't the public test utils package right?
There was a problem hiding this comment.
correct, this is private
There was a problem hiding this comment.
devongovett
reviewed
Nov 21, 2024
devongovett
previously approved these changes
Nov 21, 2024
Co-authored-by: Devon Govett <[email protected]>
devongovett
approved these changes
Nov 21, 2024
LFDanLu
approved these changes
Nov 21, 2024
## API Changes
@react-spectrum/provider/@react-spectrum/provider:Context-Context {
- UNTYPED
-} |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: