fix: DatePicker.test fails with daylight savings change (#7399) #7401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majornista
changed the title
majornista
changed the title
majornista
force-pushed
the
Issue-7399
branch
from
9bb5fb9
to
8ac1ae8
Compare
snowystinger
approved these changes
Nov 20, 2024
If the defaultValue is on daylight savings time and the user clears the value while in a time zone on standard time, the DatePicker's time zone will change to standard time. I think this is the correct behavior, however, the test is written to always expect "PDT" Pacific Daylight Savings Time, which means it will fail when we're on standard time.
majornista
force-pushed
the
Issue-7399
branch
from
8ac1ae8
to
71bde57
Compare
I discovered it when running |
devongovett
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the defaultValue is on daylight savings time and the user clears the value while in a time zone on standard time, the DatePicker's time zone will change to standard time. I think this is the correct behavior, however, the test is written to always expect "PDT" Pacific Daylight Savings Time, which means it will fail when we're on standard time.
Closes #7399
✅ Pull Request Checklist:
📝 Test Instructions:
Run
yarn test packages/@react-spectrum/datepicker/test/DatePicker.test.jsfrom the first Sunday in November to the second Sunday in March, and all tests should pass.🧢 Your Project:
Adobe/Accessibility