Fix missing required in Select (& HiddenSelect)#5026
Closed
Gregoor wants to merge 1 commit into
Closed
Conversation
Member
|
At the moment, none of our form components block native form submission. They use |
Author
|
Ah! I've been using Would a PR adding it only to |
Member
|
Yeah eventually, but it depends on the form validation stuff I linked to to avoid the browser's native validation UI. I am currently working on that, so I'll close this one out for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I noticed the lack of a
requiredprop on theSelectcomps, but I need it to block form submission. Hope it's alright to jump straight to PR without a prior issue, it seemed pretty clear to me that this will be needed.✅ Pull Request Checklist: