-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Remove defunct splitview #2644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove defunct splitview #2644
Conversation
|
Build successful! 🎉 |
|
So we might not have exported the actual component but for whatever reason it had types in react-types/shared which is a published package. |
|
@dannify great point, technically it would be breaking, though not sure who would be using them since we never released the hooks or component? |
# Conflicts: # packages/@react-spectrum/splitview/test/SplitView.test.js
a46549d
|
Build successful! 🎉 |
|
verbal approval from Devon 👍 |
Closes
Splitview is not a component we will be building. Design is finally settling and we'll have something that accomplishes similar goals, but will likely be by a different name with some different requirements. Rather than adapt this, we'll remove it for now to prevent confusion and when the new component comes along, we can look back to this if we need it.
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: