Skip to content

Conversation

@snowystinger
Copy link
Member

Closes
Splitview is not a component we will be building. Design is finally settling and we'll have something that accomplishes similar goals, but will likely be by a different name with some different requirements. Rather than adapt this, we'll remove it for now to prevent confusion and when the new component comes along, we can look back to this if we need it.

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@adobe-bot
Copy link

Build successful! 🎉

ktabors
ktabors previously approved these changes Dec 7, 2021
reidbarber
reidbarber previously approved these changes Dec 7, 2021
@dannify
Copy link
Member

dannify commented Dec 8, 2021

So we might not have exported the actual component but for whatever reason it had types in react-types/shared which is a published package.
So can we actually remove those types or is that a breaking change?

@snowystinger
Copy link
Member Author

@dannify great point, technically it would be breaking, though not sure who would be using them since we never released the hooks or component?
but maybe safer to leave them? lets get some other opinions

dannify
dannify previously approved these changes Dec 10, 2021
devongovett
devongovett previously approved these changes Dec 10, 2021
# Conflicts:
#	packages/@react-spectrum/splitview/test/SplitView.test.js
@adobe-bot
Copy link

Build successful! 🎉

@dannify
Copy link
Member

dannify commented Dec 10, 2021

verbal approval from Devon 👍

@dannify dannify merged commit e9562b2 into main Dec 10, 2021
@dannify dannify deleted the remove-defunct-splitview branch December 10, 2021 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants