Upgrade to node 14 #2027
Merged
Upgrade to node 14 #2027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14.17 introduced a breaking change where resolvedOptions returns 'decimal' instead of 'percent'. I've logged a bug here: nodejs/node#39050
|
Build successful! 🎉 |
LFDanLu
approved these changes
Jun 23, 2021
|
Build successful! 🎉 |
ktabors
reviewed
Jun 28, 2021
|
I didn't look to see if i could share between executors and they are pretty small in terms of lines, but they are different cpu sizes |
|
Build successful! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes
This appears to be good as is. Or we can wait for the parcel upgrade and see if we can move to 16 with that.
We can also do both, start with this one and open a new PR when parcel is merged
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: