Fix Popover not closing from pressing trigger #1970
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snowystinger
changed the title
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Nested modals/popovers/menu inside popover stories are broken. |
move stoppropagation and preventdefault to useoverlay
|
Build successful! 🎉 |
fix overlaytrigger state so it uses previous state
snowystinger
commented
Jun 7, 2021
| }, | ||
| toggle() { | ||
| setOpen(!isOpen); | ||
| setOpen(wasOpen => !wasOpen); |
There was a problem hiding this comment.
This happened too fast in the test and it was using the old isOpen value, so this makes that impossible, it'll always use the previous value of isOpen
devongovett
previously approved these changes
Jun 7, 2021
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
devongovett
approved these changes
Jun 8, 2021
LFDanLu
approved these changes
Jun 8, 2021
|
Build successful! 🎉 |
This was referenced Jun 11, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1155
Original bug was to fix, open popover and click trigger to close it again
May also fix double open menu
Shouldn't break FF text selection bug
nested modals should still work
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: