Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP fix invalid click event #1768

Closed
wants to merge 1 commit into from
Closed

Conversation

snowystinger
Copy link
Member

@snowystinger snowystinger commented Apr 5, 2021

Starting a PR just to discuss possible workarounds to the issue
#1513

I'm a little worried that this wouldn't be targeted enough, for instance, a link in a menu might close the menu in onPress, but the user might still expect the default 'onClick' behavior navigation instead of having to handle that themselves.

Closes

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

Starting a PR just to discuss possible workaround to the issue
@snowystinger
Copy link
Member Author

Closing this so anyone else coming along can try

@snowystinger snowystinger deleted the fix-invalid-click-event branch May 28, 2021 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant