disable ligatures in monospace code blocks. #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't understand the CI failure, if it's checking out pull/414/merge then it shouldn't need to pull the branch specifically and it can't find it because it's in my fork. Does this project not accept pull requests from forked repos? |
solimant
requested changes
Feb 15, 2024
solimant
changed the base branch from
main
to
disable-ligatures-in-code-blocks
solimant
merged commit 8f9f8b2
into
adobe:disable-ligatures-in-code-blocks
1 of 2 checks passed
10 tasks
solimant
added a commit
that referenced
this pull request
Feb 15, 2024
* disable ligatures in monospace code blocks. * Fix ordering --------- Co-authored-by: Adam Freidin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
turns off font ligatures in code blocks.
Related Issue
#413
Motivation and Context
It looks bad and is harder to read.
How Has This Been Tested?
In the brower, via dev-tools on the class declaration in question.
Screenshots (if appropriate):
Note
font-variant-ligatures: no-common-ligaturesdoes not help.(also note the screen-shot text was also edited in dev-tools, I don't remember where I found the original issue).
Types of changes
Checklist: