Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link Description is for Gatsby #24

Open
nwcell opened this issue Sep 14, 2020 · 7 comments
Open

Link Description is for Gatsby #24

nwcell opened this issue Sep 14, 2020 · 7 comments

Comments

@nwcell
Copy link

nwcell commented Sep 14, 2020

Expected Behaviour

Website description content should be relevant to my project.

Actual Behaviour

Website description content is using Gatsby boilerplate.

Reproduce Scenario (including but not limited to)

Make a site w/ parliament

Steps to Reproduce

Make a site w/ parliament

Platform and Version

Whatever https://wsk-edge.corp.adobe.com/api/v1/web/io-onboarding/parliament/gh-pages builds to

Sample Code that illustrates the problem

curl --location --request POST 'https://wsk-edge.corp.adobe.com/api/v1/web/io-onboarding/parliament/gh-pages' \
--header 'Content-Type: application/json' \
--data-raw '{
    "title": "Dynamic Workflow",
    "branch": "master",
    "git_token": "{secret_goes_here}",
    "repo_url": "https://github.com/adobe/dynamic-workflow"
}'

Logs taken while reproducing problem

image (9)
image (8)

@nwcell
Copy link
Author

nwcell commented Sep 15, 2020

Will this commit update the curl command that I'm using?

@macdonst
Copy link
Contributor

@nwcell it should take affect on your next build. In your manifest.json add a description field with what you want the description to be.

@nwcell
Copy link
Author

nwcell commented Sep 15, 2020

Where should I add it? My file already has a description attribute. Actually, now that I'm looking at it, there seems to be a few things that aren't being used...

{
  "name": "Parliament Onboarding",
  "version": "1.0.0",
  "description": "Onboarding docs for Parliament",
  "author": "DevRel Team",
  "view_type": "mdbook",
  "meta_keywords": "adobe, parliament",
  "meta_description": "default description",
  "publish_date": "30/08/2018",
  "show_edit_github_banner": false,
  "base_path": "https://raw.githubusercontent.com",
  "pages": [
    {
      "importedFileName": "readme",
      "pages": [
        {
          "importedFileName": "user_guide",
          "pages": [],
          "path": "adobe/dynamic-workflow/master/docs/user_guide.md",
          "title": "User Guide"
        },
        {
          "importedFileName": "deploy",
          "pages": [],
          "path": "adobe/dynamic-workflow/master/docs/deploy.md",
          "title": "Build/Deploy"
        },
        {
          "importedFileName": "configuration",
          "pages": [],
          "path": "adobe/dynamic-workflow/master/docs/configuration.md",
          "title": "Configurations"
        }
      ],
      "path": "adobe/dynamic-workflow/master/docs/main.md",
      "title": "Overview"
    }
  ]
}

@macdonst
Copy link
Contributor

@nwcell replace the value here: "description": "Onboarding docs for Parliament" with what you want to show up.

@nwcell
Copy link
Author

nwcell commented Sep 16, 2020

It has not updated the description.

image

@nwcell
Copy link
Author

nwcell commented Sep 16, 2020

@nwcell
Copy link
Author

nwcell commented Sep 16, 2020

curl --location --request POST 'https://wsk-edge.corp.adobe.com/api/v1/web/io-onboarding/parliament/gh-pages' \
--header 'Content-Type: application/json' \
--data-raw '{
    "title": "Dynamic Workflow",
    "branch": "master",
    "git_token": "{redacted}",
    "repo_url": "https://github.com/adobe/dynamic-workflow"
}'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants