add Kafka metric support for 3 labels #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amuraru
reviewed
Mar 17, 2022
|
thanks for this PR @ctrlaltluc - please also file this PR against banzaicloud/koperator |
Co-authored-by: Adrian Muraru <[email protected]>
amuraru
approved these changes
Mar 17, 2022
thanks for reviewing @amuraru - see banzaicloud#778 |
amuraru
added a commit
that referenced
this pull request
Mar 21, 2022
Co-authored-by: Adrian Muraru <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
PR enables Kafka JMX metrics with 3 labels, for both counters and gauges.
Why?
The current JMX Prometheus agent configuration does not support more than 2 JMX metric labels.
This results in some labels being erroneously parsed e.g.
instead of:
Checklist