Improve Date/DateTime interactions #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR includes some improvements when we interact with `Date` or
`DateTime`.
* Elixir v1.15 introduced `{Date,DateTime,NaiveDateTime,Time}.{after?/2,before?/2}`. This means that we could improve the readability on some Date/Time
comparisons.
* I also took the chance to transform some `Timex` `defdelegate` to
their native equivalent.
Finally, most of these additions only apply if we're running on
Elixir v1.15, that's why I decided to add new entries for Elixir and OTP
matrix for CI purposes.
novaugust
requested changes
Aug 1, 2023
Comment on lines
+99
to
+103
| defp style({{:., dm, [{:__aliases__, am, [:Timex]}, :today]}, funm, args}), | ||
| do: {{:., dm, [{:__aliases__, am, [:Date]}, :utc_today]}, funm, args} | ||
|
|
||
| defp style({{:., dm, [{:__aliases__, am, [:Timex]}, :now]}, funm, args}), | ||
| do: {{:., dm, [{:__aliases__, am, [:DateTime]}, :utc_now]}, funm, args} |
There was a problem hiding this comment.
let me sit on these ones -- i'd considered doing the same earlier, but nixed it as too specific to adbe internals 🤔 still, this repo is all about forcing our views on others xD
novaugust
reviewed
Aug 1, 2023
novaugust
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes some improvements when interacting with
DateorDateTime.{Date,DateTime,NaiveDateTime,Time}.{after?/2,before?/2}. This means that we could improve the readability of some Date/Time comparisons.Timexdefdelegateto their native equivalent.Finally, most of these additions only apply if we're running on Elixir v1.15, so I added new entries for Elixir and OTP matrix for CI purposes.