This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Backout change for dismissing hint list #6397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@RaymondLim Would you like to review this one? |
ghost
assigned 
|
See. Sorry for that. I'll take a look at this to see if there is a way to fix both. |
|
Looks good. This only reverts the second issue (Clear hints when nothing's left) listed in pr #6242. |
RaymondLim
added a commit
that referenced
this pull request
Jan 8, 2014
Backout change for dismissing hint list
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for #6392 .
@YuAo This backs out part of your fix for #6242 because it introduces issue #6392 which is worse. I tried to find a way to fix both, but haven't been able to find anything reasonable, so I want to make this change for now. You're welcome to take another look at this.