Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Issue #11261: keep the search bar open #11692

Closed
wants to merge 2 commits into from

Conversation

adrianhartanto0
Copy link

This change fixes issue #11261. It will prevent the Search Modal Bar from closing (if open) after a left mouse click on the main editor.This is accomplished by commenting out line 253 to line 257 and added an event listener in window.document.body for the event keydown in line 90. This is necessary to handle the closing of the search bar when ESC key is pressed when the main editor window has focus.

thejackhammer added 2 commits September 12, 2015 16:23
…as a result of clicking in the main editor. This is done by commenting out the code in line 256. The search bar will also close when the ESC key is pressed while the main editor has focus
@abose
Copy link
Contributor

abose commented Sep 13, 2015

I think it is better to close the search bar on click on the editor[current behavior]. once a search is done the context in the bar need not be retained as that is retained in the results panel.
One modification to the current behavior would be, to remember the search phrase if there is no selection when the search bar is invoked again. I would favor that workflow than to stop the popup dismiss on focus change.

@Denisov21
Copy link
Contributor

I like this PR!

@zaggino
Copy link
Contributor

zaggino commented Sep 19, 2015

I'd make this a preference @abose - I'd quite like for search bar to stay open and keep searched strings highlighted while I make changes to the editor. I can then press escape to close it when I'm finished.

@abose
Copy link
Contributor

abose commented Sep 21, 2015

+1 for preference.
Would be good if findbar rememberes the last searched phrase if there is no selection.

@ficristo ficristo changed the title Issue #11261 Issue #11261: keep the search bar open Aug 14, 2016
@ficristo
Copy link
Collaborator

Closing in favour of #11996 which seems a more complete fix.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants