Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Sample projects: remove trailing whitespace on non-blank lines, fix arrow #10926

Merged
merged 2 commits into from
May 29, 2015
Merged

Sample projects: remove trailing whitespace on non-blank lines, fix arrow #10926

merged 2 commits into from
May 29, 2015

Conversation

valtlai
Copy link
Contributor

@valtlai valtlai commented Apr 17, 2015

  • remove trailing whitespace on non-blank lines
  • fix an arrow: < to >
  • remove the blank line just before </p>

See #10920, comments 2–3

@valtlai valtlai changed the title Sample projects: remove trailing whitespace on non-empty lines, fix arrow Sample projects: remove trailing whitespace on non-blank lines, fix arrow Apr 17, 2015
@@ -57,7 +57,7 @@
<samp>
Une petite démonstration ? Placez le curseur de la souris sur la balise <!-- <samp> --> et tapez <kbd>Cmd/Ctrl + E</kbd>. Un éditeur rapide CSS apparaît en superposition, avec la règle CSS applicable. La fonction Edition rapide est également utilisable pour les attributs de classe et d’ID. Vous pouvez aussi vous en servir sur vos fichiers LESS et SCSS.

Vous pouvez créer de nouvelles règles en procédant de la même manière. Cliquez sur l’une des balises <!-- <p> --> en haut du document et appuyez sur <kbd>Cmd/Ctrl + E&lt;/kbd>. Il n’existe aucune règle associée pour le moment, mais vous pouvez cliquer sur le bouton Nouvelle règle afin d’ajouter une règle pour <!-- <p> -->.
Vous pouvez créer de nouvelles règles en procédant de la même manière. Cliquez sur l’une des balises <!-- <p> --> en haut du document et appuyez sur <kbd>Cmd/Ctrl + E</kbd>. Il n’existe aucune règle associée pour le moment, mais vous pouvez cliquer sur le bouton Nouvelle règle afin d’ajouter une règle pour <!-- <p> -->.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pantkowiak @ybayer Looks like there is an ALF issue here -- both the French & Japanese translations had this character escaped when it should not have been. We should make sure the next ALF update doesn't cause this problem to come back.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peterflynn I did some digging, and this is not an ALF issue. Somehow the opening bracket for </kbd> tag was escaped during our pre-process for translation and post-process. This was missed in post-process, because we never had such issue. I've added info about this to our instructions, so this should not be an issue in the future:)

@peterflynn
Copy link
Member

The HTML spec says > "SHOULD" be escaped as &gt;, but since it also says the motivation for that is buggy older browsers, I think we can ignore that advice -- that change here is ok.

Brackets. To learn more about how to use the key features, read on.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several other languages have this extra line also. Do you want to remove it in all of them for consistency? (Please squash commits if you do, for history cleanliness).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peterflynn Done.

abose added a commit that referenced this pull request May 29, 2015
Sample projects: remove trailing whitespace on non-blank lines, fix arrow
@abose abose merged commit 5f2ccda into adobe:master May 29, 2015
@valtlai valtlai deleted the valtlait/sample-project branch October 3, 2015 23:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants