Fix wrong entries in Standard Apple Glyph Ordering #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Three entries in that file are different from the table in Apple spec: https://developer.apple.com/fonts/TrueType-Reference-Manual/RM06/Chap6post.html I have no idea what is the source of the difference (the file has them wrong since first commit), but it causes makeotf to fail compiling feature files to TTF fonts that reference glyphs using the Apple names.
|
BTW, how do I run the test suite locally? (I added a test, but I couldn’t figure a way to run the tests). |
These steps assume that you have the afdko installed from source. If you don't, run |
miguelsousa
approved these changes
Feb 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three entries in that file are different from the table in Apple spec.
I have no idea what is the source of the difference (the file has them wrong since first commit), but it causes makeotf to fail compiling feature files to TTF fonts that reference glyphs using the Apple names.